Small fixes and optimizations for datashader operations #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Oct 31, 2016
| @@ -259,6 +277,8 @@ def _process(self, element, key=None): | |||
| categories = array.shape[-1] | |||
| if not self.p.cmap: | |||
| pass | |||
| elif isinstance(self.p.cmap, dict): | |||
| shade_opts['color_key'] = self.p.cmap | |||
| elif isinstance(self.p.cmap, Iterable): | |||
| shade_opts['color_key'] = [c for i, c in | |||
| zip(range(categories), self.p.cmap)] | |||
There was a problem hiding this comment.
Hmm; datashader keeps the cmap and color_key options separate so that there can be a default for each one of them separately, but it looks like you are using cmap for both?
There was a problem hiding this comment.
We don't have a default cmap so it just ends up using the appropriate datashader default.
There was a problem hiding this comment.
Ok, I guess that works out then.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes various improvements/optimizations for the datashader operations avoiding making copies of the data, allowing different Element types to be used and providing an explicit color key dictionary.